internal/ethapi, accounts/abi/bind/backends: implement estimate_gas_list #21268
Conversation
rjl493456442
force-pushed
the
estimate-gaslist
branch
2 times, most recently
from
9ffe4c3 to
f877680
Compare
|
@kvhnuke please open another PR to the gh-pages branch that documents this method. The docs should be on this page: |
|
Just saw this request, will do asap thank you |
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Minor comments, in general this looks good to me
There was a problem hiding this comment.
I personally prefer EstimateGasSequenced or SequencedEstimateGas -- then we could later have other Sequenced... RPC apis, and try to gather the info about all eth.sequencedXXX in one place
There was a problem hiding this comment.
I'd prefer a less generic name, perhaps sequencedCallContext
add multiple gas estimation merge fix test errors ethereum#21062 fix previous state error lint set empty previousState if not set cleanup and create state copy during DoCall create eth_estimateGasList method add comments for eth_estimateGasList enfore gasCap on eth_estimateGasList
rjl493456442
force-pushed
the
estimate-gaslist
branch
from
f877680 to
8fac719
Compare
|
Any chance we could revive this PR? Seems like a tiny change and would be very useful to a smart contract wallet I'm working on which supports sequenced transactions. Happy to do a seperate PR and do the rebase + address @holiman's comments |
|
@PhABC it's great that you want to work on it! Please note though: adding RPC functionality needs some For now though, you can start by rebasing the PR. @kvhnuke If you still want this feature, would be nice if it could be proposed as an official addition to the spec. |
|
@fjl Going back on my word, we found an alternative method of estimating gas usage of sequenced transactions without needing this new endpoint, so we likely won't be needing this method. Other people may still find it useful however. |
|
Close it since @s1na 's work. |
|
@rjl493456442 cool :) can you link to the PR with the alternate approach/work? |
|
@pkieltyka #25743 it's batch_call, and I think batch_estimateGas should be pretty similar and I am pretty sure that sina will take on it :) |
7 participants
This PR is a reworked version based on the #21106
If we want to merge this PR, please don't squash in order to keep the original commit from @kvhnuke
What's more, if we consider accepting this change, maybe we should also support executing a batch of
calls.