Skip to content

core/vm: crypt/bls12381: fixed comments in bls #21182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karalabe merged 2 commits into from
Jun 8, 2020
+3 −3
Merged

core/vm: crypt/bls12381: fixed comments in bls #21182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d179cc
core/vm: crypto/bls12381: minor code comments
MariusVanDerWijden Jun 5, 2020
b3e443a
crypto/bls12381: fix comment
MariusVanDerWijden Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/vm/contracts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ func (c *bls12381MapG1) Run(input []byte) ([]byte, error) {
return nil, err
}

// Encode the G1 point to 256 bytes
// Encode the G1 point to 128 bytes
return g.EncodePoint(r), nil
}

Expand Down
2 changes: 1 addition & 1 deletion crypto/bls12381/fp2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func newFp2() *fp2 {

func (e *fp2) fromBytes(in []byte) (*fe2, error) {
if len(in) != 96 {
return nil, errors.New("input string should be larger than 96 bytes")
return nil, errors.New("length of input string should be 96 bytes")
}
c1, err := fromBytes(in[:48])
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion crypto/bls12381/g2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (g *G2) ToBytes(p *PointG2) []byte {
return out
}

// EncodePoint encodes a point into 128 bytes.
// EncodePoint encodes a point into 256 bytes.
func (g *G2) EncodePoint(p *PointG2) []byte {
// outRaw is 96 bytes
outRaw := g.ToBytes(p)
Expand Down