cmd/faucet: delete old keystore when importing new faucet key#21173
Merged
karalabe merged 1 commit intoethereum:masterfrom Jun 4, 2020
karalabe:faucet-delete-oldaccs
Merged
cmd/faucet: delete old keystore when importing new faucet key#21173karalabe merged 1 commit intoethereum:masterfrom karalabe:faucet-delete-oldaccs
karalabe merged 1 commit intoethereum:masterfrom
karalabe:faucet-delete-oldaccs
Conversation
12 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21166 again.
This PR modified the account import so that if an old account already exists, it at least tells us what the address is. The URL we're not able to return if there are multiple old accounts existing. Maybe in that case we should error out with an even fancier issue, but that's getting even more messy that we currently are.
If there's only one previously existing account, then keystore operations will still succeed without the URL, so that should be fine-ish. This whole scenario is a bit messy tbh.