Skip to content

p2p/discv5, p2p/testing: add missing Timer.Stop calls in tests #20869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
Apr 2, 2020
Merged

p2p/discv5, p2p/testing: add missing Timer.Stop calls in tests #20869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion p2p/discv5/sim_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ func TestSimRandomResolve(t *testing.T) {

// A new node joins every 10s.
launcher := time.NewTicker(10 * time.Second)
defer launcher.Stop()
go func() {
for range launcher.C {
net := sim.launchNode(false)
Expand All @@ -55,7 +56,6 @@ func TestSimRandomResolve(t *testing.T) {
}()

time.Sleep(3 * time.Hour)
launcher.Stop()
sim.shutdown()
sim.printStats()
}
Expand Down Expand Up @@ -196,6 +196,7 @@ func randomResolves(t *testing.T, s *simulation, net *Network) {
}

timer := time.NewTimer(randtime())
defer timer.Stop()
for {
select {
case <-timer.C:
Expand Down
1 change: 1 addition & 0 deletions p2p/testing/protocolsession.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ func (s *ProtocolSession) testExchange(e Exchange) error {
t = 2000 * time.Millisecond
}
alarm := time.NewTimer(t)
defer alarm.Stop()
select {
case err := <-errc:
return err
Expand Down