rpc: add 'rpc' as always-available module#20771
Closed
meowsbits wants to merge 1 commit intoethereum:masterfrom
Closed
rpc: add 'rpc' as always-available module#20771meowsbits wants to merge 1 commit intoethereum:masterfrom
meowsbits wants to merge 1 commit intoethereum:masterfrom
Conversation
The MetadataAPI module 'rpc' is registered on the creation of a new handler. Signed-off-by: meows <b5c6@protonmail.com>
Contributor
|
Since its always available, why would a user specify it explicitly? |
Member
|
The |
Contributor
Author
|
imo at least it shouldn't print an error if the user does configure it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MetadataAPI module 'rpc' is registered on
the creation of a new handler.
Signed-off-by: meows b5c6@protonmail.com
Fixes
A incorrect error
ERROR[03-16|07:48:24.157] Unavailable modules in HTTP API list unavailable=[rpc] available="[admin debug web3 eth txpool personal ethash miner net]"is logged if a user configures--rpcapi=rpc[|,...]