eth/downloader: fix possible data race caused by inconsistent field protection#20650
Closed
Chain-Fox wants to merge 1 commit intoethereum:masterfrom
Chain-Fox:bug-5-11-inconsistent-field-protection
Closed
eth/downloader: fix possible data race caused by inconsistent field protection#20650Chain-Fox wants to merge 1 commit intoethereum:masterfrom Chain-Fox:bug-5-11-inconsistent-field-protection
Chain-Fox wants to merge 1 commit intoethereum:masterfrom
Chain-Fox:bug-5-11-inconsistent-field-protection
Conversation
Chain-Fox
requested review from
holiman,
karalabe and
rjl493456442
as code owners
Contributor
Author
|
They are FP because the lock inside setIdle() has already protected the write conducted on p.headerThroughput and p.headerIdle. I will close this PR. |
Contributor
Author
|
eth/downloader/queue.go is not FP. So I will open a new PR and remove the unnecessary patch in eth/downloader/peer.go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed inconsistency and also potential data race in eth/downloader/peer.go and eth/downloader/queue.go:
e.g. In eth/downloader/queue.go:
q.receiptPendPoolis read/written 10 times; 9 out of 10 times it is protected by q.lock.Lock(); 1 out of 10 times it is read without a Lock, which is in func CancelReceipts() on L579.A data race may happen when
CancelReceipts()and other func likeRevoke()are called in parallel.The fix is to move lock from func
cancel()to its callerCancelReceipts().The other bugs and fixes are similar.