Skip to content

consensus/clique: re-export the status struct#20331

Closed
holiman wants to merge 1 commit intoethereum:masterfrom
holiman:refix_cliqueapi
Closed

consensus/clique: re-export the status struct#20331
holiman wants to merge 1 commit intoethereum:masterfrom
holiman:refix_cliqueapi

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Nov 19, 2019

For some reason, the clique_getstatus (#20103) stopped working on #20316. Re-exporting the status struct makes the computer happy again. 🤷‍♂️

Current master:

[user@work ~]$ echo '{"jsonrpc":"2.0","method":"clique_status","params":[],"id":1}' | nc -U /tmp/geth.ipc | jq .
{
  "jsonrpc": "2.0",
  "id": 1,
  "error": {
    "code": -32601,
    "message": "the method clique_status does not exist/is not available"
  }
}

On this PR:

[user@work ~]$ echo '{"jsonrpc":"2.0","method":"clique_status","params":[],"id":1}' | nc -U /tmp/geth.ipc | jq .
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "inturnPercent": 0,
    "sealerActivity": {
      "0x70a562efc38046dd806feac16ce4b5ac4555ec89": 0
    },
    "numBlocks": 18446744073709552000
  }
}

@holiman holiman requested a review from karalabe as a code owner November 19, 2019 17:55
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Nov 19, 2019

Hmm, this should definitely not be needed. Probably needs to be fixed in package rpc instead.

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Nov 19, 2019

See #20332

@holiman holiman closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants