eth/filters: remove use of event.TypeMux for pending logs#20312
Merged
fjl merged 9 commits intoethereum:masterfrom Dec 10, 2019
Merged
eth/filters: remove use of event.TypeMux for pending logs#20312fjl merged 9 commits intoethereum:masterfrom
fjl merged 9 commits intoethereum:masterfrom
Conversation
karalabe
reviewed
Nov 20, 2019
| <-quit | ||
| return nil | ||
| }) | ||
| return nullSubscription() |
Member
There was a problem hiding this comment.
This looks really weird. Why do we have this function?
Contributor
Author
There was a problem hiding this comment.
We do this because returning a nil subscription is not allowed. nullSubscription returns a subscription that never sends anything.
karalabe
reviewed
Nov 20, 2019
Contributor
Author
|
@karalabe PTAL |
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
20 tasks
JukLee0ira
added a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Jul 11, 2024
JukLee0ira
added a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Aug 3, 2024
gzliudan
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 3, 2024
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following staticcheck warnings: