Skip to content

whisper/whisperv6: Fix issues reported by staticcheck #20288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
Nov 14, 2019
+2 −3
Merged

whisper/whisperv6: Fix issues reported by staticcheck #20288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions whisper/whisperv6/topic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
package whisperv6

import (
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/hexutil"
)

Expand All @@ -43,7 +42,7 @@ func BytesToTopic(b []byte) (t TopicType) {

// String converts a topic byte array to a string representation.
func (t *TopicType) String() string {
return common.ToHex(t[:])
return hexutil.Encode(t[:])
}

// MarshalText returns the hex representation of t.
Expand Down
2 changes: 1 addition & 1 deletion whisper/whisperv6/whisper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func (whisper *Whisper) getPeer(peerID []byte) (*Peer, error) {
return p, nil
}
}
return nil, fmt.Errorf("Could not find peer with ID: %x", peerID)
return nil, fmt.Errorf("could not find peer with ID: %x", peerID)
}

// AllowP2PMessagesFromPeer marks specific peer trusted,
Expand Down