core/state: concurrent storage and account trie updates#19938
Closed
karalabe wants to merge 3 commits intoethereum:masterfrom
karalabe:concurrent-state-updates
Closed
core/state: concurrent storage and account trie updates#19938karalabe wants to merge 3 commits intoethereum:masterfrom karalabe:concurrent-state-updates
karalabe wants to merge 3 commits intoethereum:masterfrom
karalabe:concurrent-state-updates
Conversation
holiman
reviewed
Aug 12, 2019
Member
Author
|
Although this idea might have merit, it's a bit complex, and the behavior will change drastically if we add snapshotting (it might make more sense there). Bottom line is that this PR as is is probably not valuable enough on top of master, and will only serve to make things harder to bechmark wrt snapshotting. Lets "ship" that first if good enough and revisit concurrency afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #19953.