console: run welcome message commands individually #19373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkomisi
changed the title
karalabe
reviewed
Apr 2, 2019
| } | ||
| sort.Strings(modules) | ||
| fmt.Fprintln(c.printer, " modules:", strings.Join(modules, " ")) | ||
| fmt.Fprintln(c.printer, "modules: ", strings.Join(modules, " ")) |
Member
There was a problem hiding this comment.
This was aligned, please revert.
karalabe
reviewed
Apr 2, 2019
| `console.log("instance: " + web3.version.node);`, | ||
| `console.log("coinbase: " + eth.coinbase);`, | ||
| `console.log("at block: " + eth.blockNumber + " (" + new Date(1000 * eth.getBlock(eth.blockNumber).timestamp) + ")");`, | ||
| `console.log("datadir: " + admin.datadir);`, |
Member
There was a problem hiding this comment.
This was aligned, please revert.
karalabe
reviewed
Apr 2, 2019
| `console.log("datadir: " + admin.datadir);`, | ||
| } { | ||
| c.jsre.Run(command) | ||
| } |
Member
There was a problem hiding this comment.
I don't see a reason to run commands one-by-one, it's a programming language, lets make it work in js.
Member
|
Superseded by #19374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the handling of the
JSconsole errors thrown during the evaluation of the welcome message of the geth console.