node: require LocalAppData variable#19132
Merged
karalabe merged 2 commits intoethereum:masterfrom Feb 28, 2019
Merged
Conversation
This avoids path inconsistencies on Windows XP. Hat tip to @MicahZoltu for catching this so quickly.
fjl
referenced
this pull request
Feb 19, 2019
|
Minor comment. This will result in a panic on Windows XP, but it will work for everyone on Windows 7+. If you don't otherwise support Windows XP (not sure why you would at this point, it is really old and end of lifed by Microsoft), then this change is great. |
|
Sorry for being unclear (and spamming your inbox!). Comment is correct, feedback about panic on XP was just related to PR description that said "avoids path inconsistencies on Windows XP", which the casual reader may interpret to mean "works on Windows XP". :) |
karalabe
approved these changes
Feb 28, 2019
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
I'll believe you it's correct.
hackmod
pushed a commit
to Ethersocial/go-ethersocial
that referenced
this pull request
Apr 14, 2019
* node: require LocalAppData variable This avoids path inconsistencies on Windows XP. Hat tip to @MicahZoltu for catching this so quickly. * node: fix typo
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids path inconsistencies on Windows XP.
Hat tip to @MicahZoltu for catching this so quickly.