p2p: change metered connection ip and node id#19007
p2p: change metered connection ip and node id#19007kurkomisi wants to merge 3 commits intoethereum:masterfrom
Conversation
|
@kurkomisi I don't understand why the change to |
|
@fjl you are right. When I created this PR I needed the node here for other metering purposes too, but I could resolve that more elegantly, so it might not make sense anymore. The reason why I think this change can be still useful is that otherwise on the dashboard I can't show the |
c92086f to
7070891
Compare
|
Now the node id change is reverted, and instead I introduced a new event, which is triggered after the protocol handshake, where the peer information can entirely be extracted. I think we need this, because we want to send most of the data to the dashboard. It isn't sure whether the encryption handshake event is still needed, but maybe we want to visualize the peers that manage to make the encHandshake, and fail before/during the protoHandshake, so I would keep it for the time being. |
|
Superseded by #19397 |
This PR changes two fields of the metered connection in the
p2ppackage:IP->Addrin order to include the portID->Nodein order to use the node URL instead of the pure node IDThe corresponding
MeteredPeerEventfields' types arestringin order to prevent the unwanted modification of the original objects.This can be changed using
deepcopyif needed.