trie: move dirty data to clean cache on flush#18995
Closed
karalabe wants to merge 2 commits intoethereum:masterfrom
karalabe:write-to-read-cache
Closed
trie: move dirty data to clean cache on flush#18995karalabe wants to merge 2 commits intoethereum:masterfrom karalabe:write-to-read-cache
karalabe wants to merge 2 commits intoethereum:masterfrom
karalabe:write-to-read-cache
Conversation
Member
Author
|
Superseded by #19307. |
fjl
pushed a commit
that referenced
this pull request
Mar 26, 2019
This PR is a more advanced form of the dirty-to-clean cacher (#18995), where we reuse previous database write batches as datasets to uncache, saving a dirty-trie-iteration and a dirty-trie-rlp-reencoding per block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny PR to test whether the clean cache can offset the archive performance hit of wiping the trie cache generations. For full nodes that seemed to have less impact (the dirty cache probably covering most of the trie cache generation surface), but for archive nodes the impact was too much. Lets see what happens now.