crypto, crypto/secp256k1: use libsecp256k1 for scalar multiplication#1862
Merged
obscuren merged 2 commits intoethereum:developfrom Dec 2, 2015
Merged
crypto, crypto/secp256k1: use libsecp256k1 for scalar multiplication#1862obscuren merged 2 commits intoethereum:developfrom
obscuren merged 2 commits intoethereum:developfrom
Conversation
Updated: Wed Dec 2 11:48:57 UTC 2015 |
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
2 times, most recently
from
7a4fb4c to
a8565ba
Compare
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
from
a8565ba to
fefcc50
Compare
Author
|
Looks like P2P RLPx tests fails sometimes with this patch - in progress until we figure out why. |
Contributor
|
Nice speedup :) |
Contributor
|
@Gustav-Simonsson any update on this? |
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
from
95d80c3 to
f41ee78
Compare
Current coverage is
|
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
2 times, most recently
from
b2159b3 to
95b2317
Compare
Contributor
There was a problem hiding this comment.
I think this is no longer required since you added an entry for secp256k1 in the default params registry.
Author
|
@obscuren updated, seems to work as expected. the windows build failure is unrelated. |
Contributor
There was a problem hiding this comment.
Please move this code into the curve method.
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
2 times, most recently
from
51df9ee to
5ff85a8
Compare
Contributor
|
👍 |
fjl
changed the title
Contributor
|
I think needs some rebasing |
added 2 commits
November 30, 2015 13:24
thanks to Felix Lange (fjl) for help with design & impl
Gustav-Simonsson
force-pushed
the
libsecp256k1_ecdh
branch
3 times, most recently
from
e6b5f93 to
c8ad64f
Compare
Contributor
|
@obscuren this is rebased now |
obscuren
added a commit
that referenced
this pull request
Dec 2, 2015
crypto, crypto/secp256k1: use libsecp256k1 for scalar multiplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1853 - please review & merge it first.NOTE: package
crypto/eciesneeds some refactoring love - this patch is not ideal as packageeciesis a bit messy. Discussed with @fjl and we have several ideas around how to refactor it. Would prefer to make that refactoring in a separate PR so it's easier to review separated from this change.ScalarMultfor this curve.Speedup: