cmd: allow empty bootnodes flag override#18509
Merged
fjl merged 1 commit intoethereum:masterfrom Jan 24, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding a
if url != ""check, prior to trying to parse theenodefrom the command-line arguments.Currently there is no way to specify that we want to have an empty bootnodes list in the resulting
cfg.BootstrapNodes- you can either override the bootnodes list with entries, or use the provided defaults, but never use an empty list.When we start a new deployment, and start a new bootnode, we might want it to not try to connect to any peers.