accounts/abi: allow interface as the destination#18490
Merged
gballet merged 1 commit intoethereum:masterfrom Jan 23, 2019
Merged
accounts/abi: allow interface as the destination#18490gballet merged 1 commit intoethereum:masterfrom
gballet merged 1 commit intoethereum:masterfrom
Conversation
gballet
requested changes
Jan 22, 2019
Member
gballet
left a comment
gballet
left a comment
There was a problem hiding this comment.
Those changes make sense. Have a look at the few nitpicks that I have.
Member
There was a problem hiding this comment.
You're chaning what is being tested here. See https://play.golang.org/p/jVgSuTeE1Fr
I suggest that you add a separate test with []byte{} and in this case check that you are indeed getting the error that occurs when dst.Elem().IsValid() == false
Member
There was a problem hiding this comment.
That's nice, and yet I would also like to see a test for what happens when the interface doesn't correspond do the types in def
Contributor
|
This change fixes issue #18480 :) |
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 22, 2019
FetchContractData method as it can no longer take a pointer to an empty interface which was allowing to act completely generically in our Poller methods... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 22, 2019
FetchContractData method as it can no longer take a pointer to an empty interface which was allowing to act completely generically in our Poller methods... fix provided in PR [#18490](ethereum/go-ethereum#18490)
rjl493456442
force-pushed
the
interface-destination
branch
from
bc70a8a to
9c4a95e
Compare
Member
Author
|
@gballet I moved the test cases into Since in the Please take another look. |
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 23, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
i-norden
added a commit
to vulcanize/vulcanizedb
that referenced
this pull request
Jan 24, 2019
FetchContractData method in the context of our Poller as it can no longer take a pointer to an empty interface which allowed for generic handling of any return type... fix provided in PR [#18490](ethereum/go-ethereum#18490)
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, interface as the abi unpack destination is allowed.
It means user could pass a pointer to an empty interface (v) to the
abi.Unpack(v interface{}, data []byte)method in order to unpack values returned from contract method calls without needing to know the type of the returned values beforehand(Copy from #18480 issue description).Also this PR fix #18480