Skip to content

swarm/network/simulation:commented out unreachable code-avoid vet errors #18263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zelig merged 1 commit into from
Dec 18, 2018
Merged

swarm/network/simulation:commented out unreachable code-avoid vet errors #18263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions swarm/network/simulation/example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,8 @@ package simulation_test

import (
"context"
"fmt"
"sync"
"time"

"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/node"
"github.com/ethereum/go-ethereum/p2p/simulations/adapters"
"github.com/ethereum/go-ethereum/swarm/network"
"github.com/ethereum/go-ethereum/swarm/network/simulation"
)

Expand All @@ -35,7 +29,8 @@ import (
func ExampleSimulation_WaitTillHealthy() {

log.Error("temporarily disabled as simulations.WaitTillHealthy cannot be trusted")
return

/* Commented out to avoid go vet errors/warnings

sim := simulation.New(map[string]simulation.ServiceFunc{
"bzz": func(ctx *adapters.ServiceContext, b *sync.Map) (node.Service, func(), error) {
Expand Down Expand Up @@ -75,6 +70,8 @@ func ExampleSimulation_WaitTillHealthy() {
}

// continue with the test

*/
}

// Watch all peer events in the simulation network, buy receiving from a channel.
Expand Down