Skip to content

travis: increase open file limits on macOS #18155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karalabe merged 1 commit into from
Nov 22, 2018
Merged

travis: increase open file limits on macOS #18155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ matrix:
- os: osx
go: 1.11.x
script:
- echo "Increase the maximum number of open file descriptors on macOS"
- NOFILE=20480
Copy link
Copy Markdown
Member

@gballet gballet Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for "NO FILE" or "Number Of FILE" (with a final "S" missing) ? if it's the latter, call it NOFILES to avoid the confusion.

Copy link
Copy Markdown
Member Author

@nonsense nonsense Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gballet no, don't revert changes to mailserver.go, I think it is fine as is.

Regarding NOFILE - I think this is how open file descriptors are called in Linux - for example https://wiki.archlinux.org/index.php/Limits.conf#nofile

Also it is pretty clear what this is doing based on the line above, and the commands below.

I don't have strong feelings about the name of the var, I can change to whatever if necessary.

Copy link
Copy Markdown
Member

@gballet gballet Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- sudo sysctl -w kern.maxfiles=$NOFILE
- sudo sysctl -w kern.maxfilesperproc=$NOFILE
- sudo launchctl limit maxfiles $NOFILE $NOFILE
- sudo launchctl limit maxfiles
- ulimit -S -n $NOFILE
- ulimit -n
- unset -f cd # workaround for https://github.com/travis-ci/travis-ci/issues/8703
- go run build/ci.go install
- go run build/ci.go test -coverage $TEST_PACKAGES
Expand Down