Skip to content

usbwallet: check returned error when decoding hexstr #18056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holiman merged 3 commits into from
Dec 13, 2018
Merged

usbwallet: check returned error when decoding hexstr #18056

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b172afd
usbwallet: check returned error when decoding hexstr
Nov 8, 2018
7039c56
Update accounts/usbwallet/ledger.go
holiman Dec 11, 2018
199d6b8
usbwallet: check hex decode error
CoreyLin Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion accounts/usbwallet/ledger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,9 @@ func (w *ledgerDriver) ledgerDerive(derivationPath []uint32) (common.Address, er

// Decode the hex sting into an Ethereum address and return
var address common.Address
hex.Decode(address[:], hexstr)
if _, err = hex.Decode(address[:], hexstr); err != nil {
return common.Address{}, err
}
return address, nil
}

Expand Down