Clique signing in Clef#17886
Closed
holiman wants to merge 1 commit into
Closed
Conversation
Contributor
|
This is great stuff, I think the only major missing part left is writing tests for the clique headers. Also, eventually, we're using |
Contributor
Author
|
It's not set in stone, I just decoupled this from the geth relay. I'm open to other suggestions, and/or replacing this code with what you have. |
Contributor
|
Should we dismiss this in lieu of #17789? I added your latest clique code there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ability into Clef to sign Clique headers, a prerequisite for moving account management out of Geth. The same schema with content-types will also be used for other types of signing, such as eip-712.
cc @PaulRBerg