Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

ethereum / go-ethereum Public

Notifications You must be signed in to change notification settings
Fork 21.9k
Star 51.1k

Code
Issues 182
Pull requests 195
Actions
Projects
Wiki
Security and quality 17
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security and quality
Insights

Implemented EIP191/712 in clef#17789

Merged

holiman merged 85 commits into

ethereum:masterethereum/go-ethereum:masterfrom

PaulRBerg:eip191/712Copy head branch name to clipboard

Feb 6, 2019

Conversation Commits85 (85)Checks Files changed

Merged

Implemented EIP191/712 in clef#17789
holiman merged 85 commits into
ethereum:masterfrom
PaulRBerg:eip191/712

Commits

Commits on Jan 30, 2019

Named functions and defined a basic EIP191 content type list
PaulRBerg
committed
Written basic content type functions
PaulRBerg
committed
Added ecRecover method in the clef api
PaulRBerg
committed
Updated the extapi changelog and addded indications in the README
PaulRBerg
committed
Changed the version of the external API
PaulRBerg
committed
Added tests for 0x45
PaulRBerg
committed
Implementing UnmarshalJSON() for TypedData
PaulRBerg
committed
Working on TypedData
PaulRBerg
committed
Solved the auditlog issue
PaulRBerg
committed
Changed method to signTypedData
PaulRBerg
committed
Changed mimes and implemented the 'encodeType' function for EIP-712
PaulRBerg
committed
Polished docstrings, ran goimports and swapped fmt.Errorf with errors.New where possible
PaulRBerg
committed
Drafted recursive encodeData
PaulRBerg
committed
Ran goimports and gofmt
PaulRBerg
committed
Drafted first version of EIP-712, including tests
PaulRBerg
committed
Temporarily switched to using common.Address in tests
PaulRBerg
committed
Drafted text/validator and and rewritten []byte as hexutil.Bytes
PaulRBerg
committed
Solved stringified address encoding issue
PaulRBerg
committed
Changed the property type required by signData from bytes to interface{}
PaulRBerg
committed
Fixed bugs in 'data/typed' signs
PaulRBerg
committed
Brought legal warning back after temporarily disabling it for development
PaulRBerg
committed
Added example RPC calls for account_signData and account_signTypedData
PaulRBerg
committed
Polished and fixed PR
PaulRBerg
committed
Solved malformed data panics and also wrote tests
PaulRBerg
committed
Added alphabetical sorting to type dependencies
PaulRBerg
committed
Added pretty print to data/typed UI
PaulRBerg
committed
signer: more tests for typed data

holiman
authored and
PaulRBerg
committed
Fixed TestMalformedData4 errors and renamed IsValid to Validate
PaulRBerg
committed
Fixed more new failing tests and deanonymised some functions
PaulRBerg
committed
Added types to EIP712 output in cliui
PaulRBerg
committed
Fixed regexp issues
PaulRBerg
committed
Added pseudo-failing test
PaulRBerg
committed
Fixed false positive test
PaulRBerg
committed
Added PrettyPrint method
PaulRBerg
committed
Named functions and defined a basic EIP191 content type list
PaulRBerg
committed
Written basic content type functions
PaulRBerg
committed
Added ecRecover method in the clef api
PaulRBerg
committed
Updated the extapi changelog and addded indications in the README
PaulRBerg
committed
Added tests for 0x45
PaulRBerg
committed
Implementing UnmarshalJSON() for TypedData
PaulRBerg
committed
Working on TypedData
PaulRBerg
committed
Solved the auditlog issue
PaulRBerg
committed
Changed method to signTypedData
PaulRBerg
committed
Changed mimes and implemented the 'encodeType' function for EIP-712
PaulRBerg
committed
Polished docstrings, ran goimports and swapped fmt.Errorf with errors.New where possible
PaulRBerg
committed
Drafted recursive encodeData
PaulRBerg
committed
Ran goimports and gofmt
PaulRBerg
committed
Drafted first version of EIP-712, including tests
PaulRBerg
committed
Temporarily switched to using common.Address in tests
PaulRBerg
committed
Drafted text/validator and and rewritten []byte as hexutil.Bytes
PaulRBerg
committed
Solved stringified address encoding issue
PaulRBerg
committed
Changed the property type required by signData from bytes to interface{}
PaulRBerg
committed
Fixed bugs in 'data/typed' signs
PaulRBerg
committed
Brought legal warning back after temporarily disabling it for development
PaulRBerg
committed
Added example RPC calls for account_signData and account_signTypedData
PaulRBerg
committed
Polished and fixed PR
PaulRBerg
committed
Solved malformed data panics and also wrote tests
PaulRBerg
committed
Added alphabetical sorting to type dependencies
PaulRBerg
committed
Added pretty print to data/typed UI
PaulRBerg
committed
signer: more tests for typed data

holiman
authored and
PaulRBerg
committed
Fixed TestMalformedData4 errors and renamed IsValid to Validate
PaulRBerg
committed
Fixed more new failing tests and deanonymised some functions
PaulRBerg
committed
Added types to EIP712 output in cliui
PaulRBerg
committed
Fixed regexp issues
PaulRBerg
committed
Added pseudo-failing test
PaulRBerg
committed
Fixed false positive test
PaulRBerg
committed
Added PrettyPrint method
PaulRBerg
committed
signer: refactor formatting and UI

holiman
authored and
PaulRBerg
committed
signer: make ui use new message format for signing

holiman
authored and
PaulRBerg
committed
Fixed breaking changes
PaulRBerg
committed
Fixed rules_test failing test
PaulRBerg
committed
Added extra regexp for reference types
PaulRBerg
committed
signer: more hard types

holiman
authored and
PaulRBerg
committed
Fixed failing test, formatted files
PaulRBerg
committed
signer: use golang/x keccak

holiman
authored and
PaulRBerg
committed
Fixed goimports error
PaulRBerg
committed
clef, signer: address some review concerns

holiman
authored and
PaulRBerg
committed
Implemented latest recommendations
PaulRBerg
committed
Fixed comments and uintint256 issue
PaulRBerg
committed

Commits on Feb 5, 2019

Merge branch 'master' into eip191/712
holiman
authored
accounts, signer: fix mimetypes, add interface to sign data with passphrase
holiman
committed
signer, accounts: remove duplicated code, pass hash preimages to signing
holiman
committed
signer: prevent panic in type assertions, make cliui print rawdata as quotable-safe
holiman
committed
signer: linter fixes, remove deprecated crypto dependency
holiman
committed
accounts: fix goimport
holiman
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.