rpc: url.Parse can't parse filepath in windows#17151
Closed
jsvisa wants to merge 1 commit into
Closed
Conversation
karalabe
reviewed
Jul 9, 2018
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
I don't really follow why this change solves a problem really. On Windows, IPC starts with \\ as far as I know. What does this PR meant to solve?
Contributor
Author
|
@karalabe as https://ci.appveyor.com/project/ethereum/go-ethereum/build/master.7006/job/tocjijjprtmv4tac#L1227 said:
url.Parse parse "C:\Users\appveyor\AppData\Local\Temp\1\swarm837570684/TestSwarm.ipc" scheme to "c" |
Member
|
|
Member
|
The test is supposedly fixed already on master. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #17141 said, CI failed in Windowss after PR #17041 merged, because #17041 introduced a new test case
TestNewSwarmin swarm_test.go#L38, diff. AFAIK, this bug exists for a long time, long before PR #17041, and it happened in that PR.