Skip to content

rpc: bump HTTP server timeouts#17088

Closed
yutarommx wants to merge 1 commit intoethereum:masterfrom
yutarommx:change_rpc_timeout
Closed

rpc: bump HTTP server timeouts#17088
yutarommx wants to merge 1 commit intoethereum:masterfrom
yutarommx:change_rpc_timeout

Conversation

@yutarommx
Copy link
Copy Markdown

Client connection fails by "Invalid JSON".
Timeout is too short.

Timeout is too short.
RPC connection frequently fails.
@GitCop
Copy link
Copy Markdown

GitCop commented Jun 26, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 7495bf4
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

Copy link
Copy Markdown
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the timeouts are too short, but 60 seconds feels too much. Please lower it to 30 seconds.

@fjl fjl changed the title "Invalid JSON" Measures rpc: bump HTTP server timeouts Jul 24, 2018
@karalabe
Copy link
Copy Markdown
Member

Closing in favor of #17240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants