Skip to content

build: make build/goimports.sh more potable#17087

Merged
karalabe merged 1 commit into
ethereum:masterfrom
OpenCommunityCoin:build/portable-shell
Jun 27, 2018
Merged

build: make build/goimports.sh more potable#17087
karalabe merged 1 commit into
ethereum:masterfrom
OpenCommunityCoin:build/portable-shell

Conversation

@hackmod
Copy link
Copy Markdown
Contributor

@hackmod hackmod commented Jun 26, 2018

  • #!/usr/bin/env bash => #!/bin/sh
  • -not => ! (posix compliant)
  • -wholename => -path

Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.8.12 milestone Jun 27, 2018
@karalabe karalabe merged commit e916f97 into ethereum:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants