Optimize keccak#16832
Closed
chfast wants to merge 2 commits intoethereum:masterfrom
Closed
Conversation
Contributor
|
It looks like a lot of the overhead is due to func makeHasher(h hash.Hash) hasher {
// If the hash supports Read to get the sum (like sha3.state), use it.
// This avoids the overhead of Sum.
type readerHash interface {
hash.Hash
Read([]byte) (int, error)
}
if rh, ok := h.(readerHash); ok {
outputLen := rh.Size()
return func(dest []byte, data []byte) {
rh.Reset()
rh.Write(data)
rh.Read(dest[:outputLen])
}
}
// Otherwise use Sum.
return func(dest []byte, data []byte) {
h.Reset()
h.Write(data)
h.Sum(dest[:0])
}
}Benchmark difference with this change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reimplemented Keccak main loop. This is only used in ethash cache generation. The time for epoch 200 drops from 1.8 s to 1.3 s.
Do not merge it yet.