core: Ensure that local transactions aren't discarded as underpriced#16576
Merged
karalabe merged 1 commit intoethereum:masterfrom May 2, 2018
trailtacos:bugfix/local_underpriced_txs
Merged
core: Ensure that local transactions aren't discarded as underpriced#16576karalabe merged 1 commit intoethereum:masterfrom trailtacos:bugfix/local_underpriced_txs
karalabe merged 1 commit intoethereum:masterfrom
trailtacos:bugfix/local_underpriced_txs
Conversation
vogelito
approved these changes
Apr 26, 2018
vogelito
left a comment
vogelito
left a comment
There was a problem hiding this comment.
We’re having issues with our own transactions being discarded. This is a fix for that.
Member
|
Nice catch! |
This fixes an issue where local transactions are discarded as underpriced when the pool and queue are full.
karalabe
approved these changes
May 2, 2018
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
LGTM! I've expanded the test a bit.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 9, 2024
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where local transactions are discarded as
underpriced when the pool and queue are full.