common: document Address conversion functions#16322
Closed
asymmetric wants to merge 1 commit intoethereum:masterfrom
Closed
common: document Address conversion functions#16322asymmetric wants to merge 1 commit intoethereum:masterfrom
asymmetric wants to merge 1 commit intoethereum:masterfrom
Conversation
The documentation is especially supposed to clarify which function users should call to convert a string containing an address into an Address struct.
Member
|
Thanks for these. We've been hit a few times with people using the conversion methods wrong. My suggestion would be to completely remove |
Contributor
Author
Contributor
|
Superseded by #16436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation is especially supposed to clarify which function users
should call to convert a string containing an address into an Address
struct.