Batch reuse#15989
Merged
Merged
Conversation
Contributor
Author
|
So, some graphs. Here's geth master: No big differences, biggest seems to be that the latter reaches the 'silent area' (when nothing is imported for a few minutes, due to db compaction (?)) around Can't say for sure it's due to the code changes though. |
Contributor
Author
|
With the added patch to set the
And a bit zoomed in:
|
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
* leveldb: Update leveldb to 211f780 (poolfix) * core, ethdb: reuse database batches
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
* leveldb: Update leveldb to 211f780 (poolfix) * core, ethdb: reuse database batches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes on top of #15988. This PR exposes the
Reset()interface fromleveldb.Batch, implements it for the relevant types, and uses it during block import.This should decrease the number of allocations and make the gc work less. I'll add charts to this PR to see if it makes any difference.