les: fix TxStatusMsg RLP coding#15974
Merged
Merged
Conversation
karalabe
reviewed
Jan 25, 2018
| var resp struct { | ||
| ReqID, BV uint64 | ||
| Status []core.TxStatus | ||
| Status []txStatus |
Member
There was a problem hiding this comment.
This is an odd one. Why change this? Is this a network protocol packet? If so, don't we have it declared already in protocol.go. If not, perhaps we should? Just wondering here.
Contributor
Author
There was a problem hiding this comment.
It is a protocol packet and it is declared in protocol.go. Before the cleanup there was no les.txStatus, just core.TxStatus which contained the position and error fields too. When les.txStatus was created, we forgot to replace this instance (another reason the whole thing wasn't working).
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15943
Replaces #15956