dashboard: CPU, memory, diskIO and traffic on the footer#15950
Merged
Conversation
added 10 commits
January 23, 2018 14:47
kurkomisi
force-pushed
the
dashboard-footer-mem-traff
branch
from
0fdc21b to
f4b4204
Compare
karalabe
suggested changes
Jan 23, 2018
| systemCPUUsage := gosigar.Cpu{} | ||
| systemCPUUsage.Get() | ||
| prevRead := metrics.DefaultRegistry.Get("eth/db/chaindata/compact/input").(metrics.Meter).Count() | ||
| prevWrite := metrics.DefaultRegistry.Get("eth/db/chaindata/compact/output").(metrics.Meter).Count() |
Member
There was a problem hiding this comment.
Use var to group and align these.
| return db, nil | ||
| } | ||
|
|
||
| func (db *Dashboard) emptyChartEntries(t time.Time, limit int) ChartEntries { |
Member
There was a problem hiding this comment.
Make this a standalone utility method, then you don't need db for it.
| db.charts.ProcessCPU = db.emptyChartEntries(now, processCPUSampleLimit) | ||
| db.charts.SystemCPU = db.emptyChartEntries(now, systemCPUSampleLimit) | ||
| db.charts.Read = db.emptyChartEntries(now, readSampleLimit) | ||
| db.charts.Write = db.emptyChartEntries(now, writeSampleLimit) |
Member
There was a problem hiding this comment.
Move these into the literal definition above.
kurkomisi
changed the title
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
) * dashboard: footer, deep state update * dashboard: resolve asset path * dashboard: prevent state update on every reconnection * dashboard: fix linter issue * dashboard, cmd: minor UI fix, include commit hash * dashboard: gitCommit renamed to commit * dashboard: move the geth version to the right, make commit optional * dashboard: memory, traffic and CPU on footer * dashboard: fix merge * dashboard: CPU, diskIO on footer * dashboard: rename variables, use group declaration * dashboard: docs
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
) * dashboard: footer, deep state update * dashboard: resolve asset path * dashboard: prevent state update on every reconnection * dashboard: fix linter issue * dashboard, cmd: minor UI fix, include commit hash * dashboard: gitCommit renamed to commit * dashboard: move the geth version to the right, make commit optional * dashboard: memory, traffic and CPU on footer * dashboard: fix merge * dashboard: CPU, diskIO on footer * dashboard: rename variables, use group declaration * dashboard: docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChartRowcomponent is created for the responsive equally sized charts.CustomTooltipcomponent is created for the custom display of the active chart sample.(prev, update)to(update, prev), because prev is not always needed (i.e.replacer)appenderfunction now can apply a mapper to the update data.