p2p/discv5: logs info about discv5 node info at bind time#15948
Merged
Conversation
Member
|
SGTM, but how does this relate to the unified port handling merged yesterday? |
Contributor
Author
|
No idea whatsoever. I updated to the most recent code, checked what the problem was, fixed it. Didn't look very unified to me... |
Member
|
;P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-v5is specified, the node does not output node-info at startup.The following was show (not
-v5) even before this PR:With this PR,
-v5behaves similarly: