dashboard: deep state update, footer by kurkomisi · Pull Request #15837 · ethereum/go-ethereum

kurkomisi · 2018-01-09T12:06:08Z

bundle.js and dashboard.html is moved to the root directory.
An own deep state updater replaces ramda.js.
- The state of a React component is a JSON object, which needs to be immutable, and in order to keep this rule a state property needs to be changed completely during an update. This causes a problem, when one wants to nest objects in the state, because React doesn't change a small part of the nested object, but completely replaces it. The dashboard relies on such nested objects, which trigger the rerendering of some parts of the UI. In order to handle the deep update the deepUpdate function is used, which copies the original state property, and updates the concerned object properties. For the maximal flexibility of the update an auxiliary JSON object is used, which has the same structure as the state, except that it contains update handler functions.
- It turns out that the server message and the state content can possess identical structure, so there is no need for handling the different parts of the incoming message, because the deep updater does it already. As a consequence an incoming message triggers all the relevant renders of the UI without further effort.
shouldUpdate contains the structure of the incoming message, and it is used at the shouldComponentUpdate methods to check whether the data connected to the actual component was affected or not.
Footer is included with the geth version on it.
The message structure is changed both on server and client side.

karalabe · 2018-01-10T09:22:21Z

Ok, this is a bit crude on the UI side :P

Instead of one big 1.8.0-unstable, lets be a bit more specific with it. Something like:

Geth v1.8.0 (unstable)
Commit 12345678

Similar in styling to https://pbs.twimg.com/media/DMQdz7tW4AA_qlX.jpg:large

The (unstable) should only appear if unstable, and nothing should if it's a stable build. The commit hash is again optional, if we have one, display it, otherwise nothing. Also lets push it out to the right edge of the footer.

karalabe

^

GitCop · 2018-01-11T21:19:28Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 53f04096a74238406109eacca62abc29684edbfb
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

karalabe · 2018-01-11T21:29:20Z

 type GeneralMessage struct {
-	Version string `json:"version,omitempty"`
+	Version   string `json:"version,omitempty"`
+	GitCommit string `json:"gitCommit,omitempty"`


Call this just Commit pls, also in the json, just commit.

karalabe · 2018-01-11T21:29:43Z


 // New creates a new dashboard instance with the given configuration.
-func New(config *Config) (*Dashboard, error) {
+func New(config *Config, gitCommit string) (*Dashboard, error) {


commit is enough

karalabe · 2018-01-11T21:29:49Z

+	listener  net.Listener
+	conns     map[uint32]*client // Currently live websocket connections
+	charts    *HomeMessage
+	gitCommit string


commit pls

karalabe · 2018-01-11T21:30:36Z


 export type General = {
 	version: string,
+	gitCommit: string,


GitCop · 2018-01-11T21:44:41Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: cbdb465
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

karalabe · 2018-01-12T09:22:31Z

Please move commit under the version, style Geth and Commit a bit darker, make the fonts smaller, these aren't that important infos, just useful to have and move everything to the right side.

GitCop · 2018-01-12T11:48:54Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: cbdb465
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-01-12T15:48:15Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: cbdb465
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-01-12T16:02:06Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: cbdb465
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

karalabe

LGTM!

* dashboard: footer, deep state update * dashboard: resolve asset path * dashboard: remove bundle.js * dashboard: prevent state update on every reconnection * dashboard: fix linter issue * dashboard, cmd: minor UI fix, include commit hash * remove geth binary * dashboard: gitCommit renamed to commit * dashboard: move the geth version to the right, make commit optional * dashboard: commit limited to 7 characters * dashboard: limit commit length on client side * dashboard: run go generate

Kurkó Mihály added 5 commits January 8, 2018 17:25

dashboard: footer, deep state update

fe7a4cc

dashboard: resolve asset path

dc46748

dashboard: remove bundle.js

8cfb146

dashboard: prevent state update on every reconnection

cb37e3a

dashboard: fix linter issue

011ab36

karalabe suggested changes Jan 10, 2018

View reviewed changes

karalabe added this to the 1.8.0 milestone Jan 10, 2018

dashboard, cmd: minor UI fix, include commit hash

2488050

remove geth binary

cbdb465

karalabe suggested changes Jan 11, 2018

View reviewed changes

dashboard: gitCommit renamed to commit

e9e7e5c

kurkomisi force-pushed the dashboard-footer branch from 53f0409 to e9e7e5c Compare January 11, 2018 21:44

dashboard: move the geth version to the right, make commit optional

2613348

dashboard: commit limited to 7 characters

9a46b5c

Kurkó Mihály added 2 commits January 12, 2018 18:00

dashboard: limit commit length on client side

5799717

dashboard: run go generate

ba209ef

karalabe approved these changes Jan 15, 2018

View reviewed changes

karalabe merged commit 938cf45 into ethereum:master Jan 15, 2018

karalabe removed this from the 1.8.0 milestone Jan 15, 2018

5chdn mentioned this pull request Jan 30, 2018

Merge go-ethereum updates into 2.5.4 Musicoin/go-musicoin#77

Merged

Conversation

kurkomisi commented Jan 9, 2018

Uh oh!

karalabe commented Jan 10, 2018

Uh oh!

karalabe left a comment

Choose a reason for hiding this comment

Uh oh!

GitCop commented Jan 11, 2018

Uh oh!

karalabe Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

karalabe Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

karalabe Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

karalabe Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

GitCop commented Jan 11, 2018

Uh oh!

karalabe commented Jan 12, 2018

Uh oh!

GitCop commented Jan 12, 2018

Uh oh!

GitCop commented Jan 12, 2018

Uh oh!

GitCop commented Jan 12, 2018

Uh oh!

karalabe left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants