Skip to content

cmd/ethkey: fix formatting, review nits#15807

Merged
fjl merged 3 commits into
ethereum:masterfrom
fjl:ethkey-fixups
Jan 16, 2018
Merged

cmd/ethkey: fix formatting, review nits#15807
fjl merged 3 commits into
ethereum:masterfrom
fjl:ethkey-fixups

Conversation

@fjl
Copy link
Copy Markdown
Contributor

@fjl fjl commented Jan 4, 2018

This PR:

  • Adds a --msgfile option to read the message to sign from a file
    instead of command line argument.
  • Adds a unit test for signing subcommands.
  • Removes some weird whitespace in the code.

fjl added 2 commits January 2, 2018 12:33
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
@fjl fjl requested a review from holiman January 4, 2018 11:56
Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl
Copy link
Copy Markdown
Contributor Author

fjl commented Jan 16, 2018

go vet issue resolved, waiting for CI.

@fjl fjl merged commit f08cd94 into ethereum:master Jan 16, 2018
@karalabe karalabe added this to the 1.8.0 milestone Jan 16, 2018
prestonvanloon pushed a commit to prestonvanloon/go-ethereum that referenced this pull request Apr 2, 2018
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
MariusVanDerWijden pushed a commit to MariusVanDerWijden/go-ethereum that referenced this pull request Feb 2, 2026
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants