Skip to content

rpc: Allow OPTIONS requests without Content-type: application/json#15759

Merged
fjl merged 1 commit into
ethereum:masterfrom
sorin:sorin-cors-options
Dec 28, 2017
Merged

rpc: Allow OPTIONS requests without Content-type: application/json#15759
fjl merged 1 commit into
ethereum:masterfrom
sorin:sorin-cors-options

Conversation

@sorin
Copy link
Copy Markdown
Contributor

@sorin sorin commented Dec 26, 2017

No description provided.

@fjl fjl merged commit 5369a5c into ethereum:master Dec 28, 2017
@sorin sorin deleted the sorin-cors-options branch December 28, 2017 17:29
@karalabe karalabe added this to the 1.8.0 milestone Dec 29, 2017
@lionello
Copy link
Copy Markdown
Contributor

lionello commented Mar 4, 2018

Is it me, or does this patch allow RPC using the OPTIONS verb:

$ curl -d '{"json-rpc":"2.0","id":2,"method":"eth_syncing"}' http://localhost:8545 -X OPTIONS
{"jsonrpc":"2.0","id":2,"result":false}

Note the absence of CORS headers and no Content-Type necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants