core: silence txpool reorg warning (annoying on import)#15725
Merged
karalabe merged 1 commit intoDec 21, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever the blockchain does a reorg, the transaction pool needs to load up all the transactions that went missing in the process. If the reorg is deeper than 64 blocks, the pool ignored it and warns us. If however we're importing big batches of blocks (full sync, fast sync end, or catching up), we're constantly being "warned", which gets annoying fast.
Since this warning was mostly inserted to detect errors with the new logic (which seems to work correctly), I think we can lower it from WARN to DEBUG. The blockchain will still warn us of large reorgs, so there's no inherent added value here, as long as the txpool works correctly in handling them.