crypto: ensure that VerifySignature rejects malleable signatures#15708
Merged
Conversation
It already rejected them when using libsecp256k1, make sure the nocgo version does the same thing.
Contributor
|
This change hardcodes |
Contributor
Author
|
VerifySignature is a new function and is not used anywhere in the codebase, so I doubt that there will be any issues with consensus. |
karalabe
reviewed
Dec 20, 2017
| } | ||
| if !ValidateSignatureValues(0, sig.R, sig.S, true) { | ||
| return false | ||
| } |
Member
There was a problem hiding this comment.
Out of curiosity, why is the v always 0 here?
Contributor
Author
|
There seems to be a lot of confusion about the use of ValidateSignatureValues here. The check is simpler now, PTAL. |
b00ris
pushed a commit
to b00ris/go-ethereum
that referenced
this pull request
Jan 19, 2018
…ereum#15708) * crypto: ensure that VerifySignature rejects malleable signatures It already rejected them when using libsecp256k1, make sure the nocgo version does the same thing. * crypto: simplify check * crypto: fix build
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
…ereum#15708) * crypto: ensure that VerifySignature rejects malleable signatures It already rejected them when using libsecp256k1, make sure the nocgo version does the same thing. * crypto: simplify check * crypto: fix build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It already rejected them when using libsecp256k1, make sure the nocgo
version does the same thing.