console: Fix missing console history with testnet#15700
Merged
Conversation
* Fixes ethereum#15672 by creating the datadir when stopping the console to prevent failing to save the history if no datadir exists
fjl
approved these changes
Dec 19, 2017
b00ris
pushed a commit
to b00ris/go-ethereum
that referenced
this pull request
Jan 19, 2018
Fixes ethereum#15672 by creating the datadir when creating the console. This prevents failing to save the history if no datadir exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--testnetas far as I can see