cmd/utils: Add check on hard limit, skip test if below target#15684
Merged
Conversation
Member
|
This will fail building on Windows since file descriptor limits are handled differently there. I think it's fine to reduce the test target from 4K to 2K. That would solve your issue without requiring fancier changes. Alternatively you could add a |
Contributor
Author
|
Thanks @karalabe , adjusted. |
fjl
requested changes
Dec 19, 2017
| // per this process can be retrieved. | ||
| func TestFileDescriptorLimits(t *testing.T) { | ||
| target := 4096 | ||
| var limit syscall.Rlimit |
Contributor
There was a problem hiding this comment.
Please avoid using the syscall.Rlimit type here to make the Windows build pass.
karalabe
approved these changes
Dec 21, 2017
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
LGTM! Will merge when green. Pushed some minor doc additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #15683