Skip to content

core/vm: Remove snapshot param from Interpreter.Run()#15674

Merged
karalabe merged 1 commit into
ethereum:masterfrom
chfast:vm-no-snapshot-param
Dec 18, 2017
Merged

core/vm: Remove snapshot param from Interpreter.Run()#15674
karalabe merged 1 commit into
ethereum:masterfrom
chfast:vm-no-snapshot-param

Conversation

@chfast
Copy link
Copy Markdown
Member

@chfast chfast commented Dec 14, 2017

No description provided.

@karalabe
Copy link
Copy Markdown
Member

CI is failing on this one @chfast.

@chfast
Copy link
Copy Markdown
Member Author

chfast commented Dec 15, 2017

Sorry, yes. Looks like make does not build everything...

@karalabe
Copy link
Copy Markdown
Member

Make doens't run the tests.

@chfast chfast force-pushed the vm-no-snapshot-param branch from f8d78b4 to fb5f25e Compare December 15, 2017 12:36
@chfast
Copy link
Copy Markdown
Member Author

chfast commented Dec 15, 2017

Fixed.

@chfast
Copy link
Copy Markdown
Member Author

chfast commented Dec 18, 2017

Ping.

Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@karalabe karalabe added this to the 1.8.0 milestone Dec 18, 2017
@karalabe karalabe merged commit fe070ab into ethereum:master Dec 18, 2017
@chfast chfast deleted the vm-no-snapshot-param branch December 18, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants