Skip to content

build: update linter to v2#15650

Merged
fjl merged 5 commits into
ethereum:masterfrom
zramsay:linter-update-to-v2
Dec 12, 2017
Merged

build: update linter to v2#15650
fjl merged 5 commits into
ethereum:masterfrom
zramsay:linter-update-to-v2

Conversation

@zramsay
Copy link
Copy Markdown
Contributor

@zramsay zramsay commented Dec 11, 2017

@zramsay
Copy link
Copy Markdown
Contributor Author

zramsay commented Dec 11, 2017

consensus/clique/clique.go:633: undefined: time.Until <= not in go1.7
probably worth bumping min version to go1.8

@fjl
Copy link
Copy Markdown
Contributor

fjl commented Dec 11, 2017

Thank you for resubmitting. We don't want to bump the required go version to 1.7 yet.

@zramsay
Copy link
Copy Markdown
Contributor Author

zramsay commented Dec 12, 2017

got travis passing with the nolint tag where relevant

@fjl fjl merged commit 3da1bf8 into ethereum:master Dec 12, 2017
@zramsay zramsay deleted the linter-update-to-v2 branch December 12, 2017 19:41
@karalabe karalabe added this to the 1.8.0 milestone Dec 14, 2017
b00ris pushed a commit to b00ris/go-ethereum that referenced this pull request Jan 19, 2018
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants