crypto: fix error check in toECDSA#15632
Merged
Merged
Conversation
fjl
force-pushed
the
crypto-to-ecdsa-error
branch
2 times, most recently
from
ed52021 to
fe0395f
Compare
fjl
force-pushed
the
crypto-to-ecdsa-error
branch
from
fe0395f to
7ce1df2
Compare
b00ris
pushed a commit
to b00ris/go-ethereum
that referenced
this pull request
Jan 19, 2018
With this change,
key, err := crypto.HexToECDSA("000000...")
returns nil key and an error instead of a non-nil key with nil X
and Y inside. Issue found by @guidovranken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change,
returns nil key and an error instead of a non-nil key with nil X and Y inside.
Found by @guidovranken.