crypto, crypto/secp256k1: add CompressPubkey #15626
Merged
Merged
Conversation
holiman
approved these changes
Dec 8, 2017
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Fwiw, it looks good to me. It wouldn't hurt with a few more testcases though, it seems like there's only one testcase, and that one decompresses a key and that's it (?)
Contributor
Author
|
@holiman PTAL |
holiman
approved these changes
Dec 14, 2017
gyn7561
added a commit
to gyn7561/go-ethereum
that referenced
this pull request
Dec 18, 2017
crypto, crypto/secp256k1: add CompressPubkey (ethereum#15626)
b00ris
pushed a commit
to b00ris/go-ethereum
that referenced
this pull request
Jan 19, 2018
This adds the inverse to DecompressPubkey and improves a few minor details in crypto/secp256k1.
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
This adds the inverse to DecompressPubkey and improves a few minor details in crypto/secp256k1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.