cmd/utils, eth: init etherbase from within eth#15528
Merged
Merged
Conversation
fjl
approved these changes
Dec 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
etherbaseaccount was previously configured aseth.accounts[0]from both withinethas well as from the outside incmd/flags. There's no need for theflagspackage to start poking around in the keystore, letethdo its job.Long term we'd like to get rid of
--etherbase=indexand--unlock=indexaltogether, though that will probably take a bit of time with warning users about it, so let's just add a deprecation warning for now and drop support in a few versions down the line only. This is needed to fully remove theflagspackage's access to the keystore.