cmd/geth: fix passing datadir flag to attach subcommand

[MaximilianMeister]

the datadir flag wasn't respected, instead you had to provide an
additional argument, which was unclear from a usage point of view

Signed-off-by: Maximilian Meister mmeister@suse.de

I tried the following on a private network:

geth --datadir /etc/testnet/miner attach
Fatal: Unable to attach to remote geth: dial unix /root/.ethereum/geth.ipc: connect: no such file or directory
command terminated with exit code 1

[tsarpaul]

You could remove the append here.

[karalabe]

Perhaps we should fix the subcommand to accept --datadir instead?

[MaximilianMeister]

Perhaps we should fix the subcommand to accept --datadir instead?

@karalabe is this the right way to fix it? i just assumed that the ipc endpoint will always be called geth.ipc
not 100% sure if that's the case, i just guess so because there is no --ipcpath option for attach to override it

[lion22]

0

[lion22]

 конечная точка  : = ctx. Args (). Первый ()

• если ctx. GlobalIsSet (utils. DataDirFlag . Name ) {
• endpoint = fmt. Sprintf ( " % s /geth.ipc " , ctx. GlobalString (utils. DataDirFlag . Name ))
  +}
• клиент , err : = dialRPC (конечная точка)

[fjl]

This is fine, but please use --datadir only if the first argument is not set.

[MaximilianMeister]

@fjl done, thanks

[fjl]

Please remove unnecessary parens here. You can write endpoint == "" && ctx.GlobalIsSet(utils.DataDirFlag.Name).

[MaximilianMeister]

@fjl sure, fixed