Skip to content

accounts/keystore: change modtime for test case files to be bigger than 1sec.#15498

Merged
karalabe merged 2 commits into
ethereum:masterfrom
nonsense:account_cache_modtime_test_fix
Nov 24, 2017
Merged

accounts/keystore: change modtime for test case files to be bigger than 1sec.#15498
karalabe merged 2 commits into
ethereum:masterfrom
nonsense:account_cache_modtime_test_fix

Conversation

@nonsense
Copy link
Copy Markdown
Member

On OSX Sierra FileInfo.ModTime always returns nsec=0, which breaks the algorithm at fileCache.scanFiles. A simple fix is to make sure that changes to keystore files in tests do not happen within the same second.

Copy link
Copy Markdown
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants