accounts, internal: return an error if no suitable estimated gas found#15477
Merged
Conversation
karalabe
suggested changes
Nov 14, 2017
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
Almost :) The original hi limit may be valid, so you need do veirify it before assuming it will fail.
E.g. I call estimate gas with the exact amount required (21000 for a plain tx).
karalabe
suggested changes
Nov 14, 2017
Member
There was a problem hiding this comment.
Please make 'Gas' is the message lowercase. All errors should be lowercase to allow composing them (the error above this is the exception as it refers to a public type)
rjl493456442
force-pushed
the
improve_gas_estimation
branch
from
1cfeb15 to
e6a9ff9
Compare
karalabe
approved these changes
Nov 14, 2017
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
I've pushed a tiny polish commit to make the code look a bit nicer :) Will squash and merge when green.
|
Fixes #15421 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.