eth: fix debug.storageRangeAt return value#15476
Merged
Merged
Conversation
StorageRangeAt use the Split function to decode the values.
Contributor
|
Could you check (with the fix) the values returned for empty value? |
Contributor
Author
|
With the fix an empty value returns an empty storage array: Deployed on Rinkeby at : This is the expected behavior right? |
Contributor
Author
|
ping @fjl |
fjl
approved these changes
Dec 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes #15196
To test this PR I deployed on Rinkeby this contract:
The modification can be checked with this call:
It should return 0x80 instead of 0x8180 before.