Update swarm chequebook for latest Solidity#15425
Merged
Merged
Conversation
fjl
approved these changes
Nov 6, 2017
Member
Author
|
I think the bytecode in the .go file needs to be updated before merging this. Is that so @nagydani? |
axic
commented
Nov 6, 2017
| bytes32 hash = sha3(address(this), beneficiary, amount); | ||
| if(owner != ecrecover(hash, sig_v, sig_r, sig_s)) return; | ||
| bytes32 hash = keccak256(address(this), beneficiary, amount); | ||
| require(owner == ecrecover(hash, sig_v, sig_r, sig_s)); |
Member
Author
There was a problem hiding this comment.
These two require changes change behaviour: before if the owner/amount didn't match, it resulted in a successful execution without doing anything; now it results in a failed execution using the revert opcode (remainder gas is not consumed).
There was a problem hiding this comment.
I think, it is okay. The actual effect is the same: nothing changes in the state and remaining gas is not consumed.
Ethereum Foundation changed email domain.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.