mobile: fixed FilterLogs#15418
Merged
Merged
Conversation
It used to write a pointer to a local variable, that led to fill a result array with the latest log
ferhatelmas
reviewed
Nov 3, 2017
| res := make([]*types.Log, len(rawLogs)) | ||
| for i, log := range rawLogs { | ||
| res[i] = &log | ||
| for i, _ := range rawLogs { |
Contributor
There was a problem hiding this comment.
👍 but why to keep blank identifier?
Contributor
Author
There was a problem hiding this comment.
I'm not a go developer and didn't know that return parameters are optional.
Removed it and the code is compiled.
I'll update the PR soon.
removed the unnecessary variable
ferhatelmas
approved these changes
Nov 3, 2017
fjl
approved these changes
Nov 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to write a pointer to a local variable,
that led to fill a result array with the latest log